Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some fixes #32

wants to merge 2 commits into from

Conversation

Azzaare
Copy link
Collaborator

@Azzaare Azzaare commented Feb 22, 2023

Update dependencies

  • LightGraphs -> Graphs

Fix signature for magnify with a default value :MIMO for the last argument.

Fix empty Symbol("") in sherlock_UI. It works with Shelock module, but not with Graphs. Still need more fixes?

@Azzaare Azzaare requested a review from caseykneale February 22, 2023 05:32
@Azzaare Azzaare added bug Something isn't working help wanted Extra attention is needed labels Feb 22, 2023
@Azzaare Azzaare mentioned this pull request Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #32 (62df5f0) into master (650f7a4) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           master     #32      +/-   ##
=========================================
- Coverage    9.33%   9.03%   -0.31%     
=========================================
  Files           3       3              
  Lines         150     155       +5     
=========================================
  Hits           14      14              
- Misses        136     141       +5     
Impacted Files Coverage Δ
src/visualizations.jl 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants