Skip to content

Commit

Permalink
Don't use the nested scroll view in Column
Browse files Browse the repository at this point in the history
This breaks overscroll.

I looked into the PR that added this, which was an attempt
to work-around a problem where a RecyclerView was nested
in a scrollable column. We shouldn't ever do that, so this
work-around should be unnecessary.
  • Loading branch information
squarejesse committed Feb 7, 2025
1 parent adb5c57 commit 5f51f50
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Changed:
- Nothing yet!

Fixed:
- Nothing yet!
- Don't use NestedScrollView for Android's Overflow.Scroll. It doesn't implement overscroll as well.


## [0.17.0] - 2025-01-30
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import android.view.View
import android.view.View.OnScrollChangeListener
import android.view.ViewGroup
import android.widget.HorizontalScrollView
import android.widget.ScrollView
import androidx.core.view.children
import androidx.core.widget.NestedScrollView
import androidx.core.widget.NestedScrollView.OnScrollChangeListener as OnScrollChangeListenerCompat
Expand Down Expand Up @@ -226,7 +227,7 @@ internal class ViewFlexContainer(
isFillViewport = true
}
} else {
NestedScrollView(context).apply {
ScrollView(context).apply {
isFillViewport = true
}
}.apply {
Expand Down

0 comments on commit 5f51f50

Please sign in to comment.