Skip to content

Commit

Permalink
Don't use the nested scroll view in Column
Browse files Browse the repository at this point in the history
This breaks overscroll.

I looked into the PR that added this, which was an attempt
to work-around a problem where a RecyclerView was nested
in a scrollable column. We shouldn't ever do that, so this
work-around should be unnecessary.
  • Loading branch information
squarejesse committed Feb 7, 2025
1 parent adb5c57 commit 7294526
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import android.widget.HorizontalScrollView
import androidx.core.view.children
import androidx.core.widget.NestedScrollView
import androidx.core.widget.NestedScrollView.OnScrollChangeListener as OnScrollChangeListenerCompat
import android.widget.ScrollView
import app.cash.redwood.Modifier
import app.cash.redwood.layout.api.Constraint
import app.cash.redwood.layout.api.CrossAxisAlignment
Expand Down Expand Up @@ -226,7 +227,7 @@ internal class ViewFlexContainer(
isFillViewport = true
}
} else {
NestedScrollView(context).apply {
ScrollView(context).apply {
isFillViewport = true
}
}.apply {
Expand Down

0 comments on commit 7294526

Please sign in to comment.