Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUT-05: description for invoice, integration test without bolt11 decode #176

Merged
merged 3 commits into from
Sep 9, 2024
Merged

NUT-05: description for invoice, integration test without bolt11 decode #176

merged 3 commits into from
Sep 9, 2024

Conversation

callebtc
Copy link
Contributor

@callebtc callebtc commented Sep 8, 2024 •
edited
Loading

Implements cashubtc/nuts#144

Egge21M
Egge21M requested changes Sep 8, 2024
View reviewed changes
src/CashuWallet.ts Outdated Show resolved Hide resolved
src/model/types/wallet/payloads.ts Outdated Show resolved Hide resolved
@Egge21M
Copy link
Collaborator

Egge21M commented Sep 9, 2024

LGTM. What's the support on this? Should we validate the reponse and add a warning if the invoice memo does not contain the expected message?

@callebtc
Copy link
Contributor Author

callebtc commented Sep 9, 2024

LGTM. What's the support on this? Should we validate the reponse and add a warning if the invoice memo does not contain the expected message?

No, that would be overkill. This is enough.

@callebtc callebtc merged commit 8909ece into development Sep 9, 2024
4 checks passed
@callebtc callebtc deleted the nut-05-invoice-description branch September 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Egge21M Egge21M Egge21M requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callebtc @Egge21M