feat: nut19 signature on mint request #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lollerfirst
reviewed
Nov 12, 2024
|
|
||
| ## Settings | ||
|
|
||
| The settings for this NUT indicate the support for requiring a signature before minting. They are part of the info response of the mint ([NUT-06][06]) which in this case reads |
There was a problem hiding this comment.
Suggested change
| The settings for this NUT indicate the support for requiring a signature before minting. They are part of the info response of the mint ([NUT-06][06]) which in this case reads | |
| The settings for this NUT indicate the support for requiring a signature before minting. They are part of the info response of the mint ([NUT-06](06.md)) which in this case reads |
There was a problem hiding this comment.
Another way how to fix the issue is to add the following at the end of the file:
[06]: 06.mdThis seems to be preferred way used in other documents.
|
@thesimplekid Should we make it clear that wallets should use an ephemeral (one time) key? |
lollerfirst
reviewed
Nov 12, 2024
| @@ -16,6 +16,7 @@ | |||
| | 20005 | Quote is pending | [NUT-04][04], [NUT-05][05] | | |||
| | 20006 | Invoice already paid | [NUT-05][05] | | |||
| | 20007 | Quote is expired | [NUT-04][04], [NUT-05][05] | | |||
| | 20008 | Witness not provided for mint quote | [NUT-19][19] | | |||
There was a problem hiding this comment.
We need an error for the invalid witness as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This NUT defines a protocol extension that enables signature-based authentication for mint quote redemption. When requesting a mint quote, clients can provide a public key. The mint will then require a valid signature from the corresponding secret key before processing the mint.
This is defined as an optional extension to NUT-04 and the intention is to reuse it and make it mandatory for bolt12 and onchain.