use integer division as per https://github.com/cashubtc/nuts/pull/126…

…\#discussion_r1625244955
cashubtc · Jun 16, 2024 · aeb0e59 · aeb0e59
1 parent d30b1a2
commit aeb0e59
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/cashu/mint/verification.py b/cashu/mint/verification.py
@@ -1,4 +1,3 @@
-import math
 from typing import Dict, List, Literal, Optional, Tuple, Union
 
 from loguru import logger
@@ -256,7 +255,7 @@ def _verify_units_match(
     def get_fees_for_proofs(self, proofs: List[Proof]) -> int:
         if not len(set([self.keysets[p.id].unit for p in proofs])) == 1:
             raise TransactionUnitError("inputs have different units.")
-        fee = math.ceil(sum([self.keysets[p.id].input_fee_ppk for p in proofs]) / 1000)
+        fee = (sum([self.keysets[p.id].input_fee_ppk for p in proofs]) + 999) // 1000
         return fee
 
     def _verify_equation_balanced(

diff --git a/cashu/wallet/transactions.py b/cashu/wallet/transactions.py
@@ -1,4 +1,3 @@
-import math
 import uuid
 from typing import Dict, List, Tuple, Union
 
@@ -24,13 +23,13 @@ class WalletTransactions(SupportsDb, SupportsKeysets):
     unit: Unit
 
     def get_fees_for_keyset(self, amounts: List[int], keyset: WalletKeyset) -> int:
-        fees = max(math.ceil(sum([keyset.input_fee_ppk for a in amounts]) / 1000), 0)
+        fees = max((sum([keyset.input_fee_ppk for a in amounts]) + 999) // 1000, 0)
         return fees
 
     def get_fees_for_proofs(self, proofs: List[Proof]) -> int:
         # for each proof, find the keyset with the same id and sum the fees
         fees = max(
-            math.ceil(sum([self.keysets[p.id].input_fee_ppk for p in proofs]) / 1000), 0
+            (sum([self.keysets[p.id].input_fee_ppk for p in proofs]) + 999) // 1000, 0
         )
         return fees