Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNbits compatibility: use bip32 from embit if bip32 lib is not available #406

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Feb 5, 2024

For LNbits. This will not be merged into the nutshell main project.

  • uses embit if bip32 is not available
  • uses multiple db transactions during mint migration because lnbits db locks otherwise

@callebtc callebtc changed the title LNbits: use embit for key generation LNbits: use bip32 from embit if bip32 lib is not available Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 67.86%. Comparing base (e040479) to head (a3c4399).
Report is 1 commits behind head on main.

Files Patch % Lines
cashu/core/crypto/keys.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   67.89%   67.86%   -0.04%     
==========================================
  Files          76       76              
  Lines        6815     6827      +12     
==========================================
+ Hits         4627     4633       +6     
- Misses       2188     2194       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc marked this pull request as ready for review February 5, 2024 16:44
@callebtc callebtc marked this pull request as draft February 5, 2024 16:44
@callebtc callebtc changed the title LNbits: use bip32 from embit if bip32 lib is not available LNbits compatibility: use bip32 from embit if bip32 lib is not available Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant