Proposition of changes into Casper Types to support a Rust SDK for 1.6 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to reopen the PR from a new branch to keep the SDK compilation working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to pull changes made for the Rust SDK. It is adding a sdk feature and affects several methods or expose them accordingly to be able to compile the SDK.
This PR has a strong dependency on PR against node 1.6 casper-network/casper-node#4348
Right now this feature only build with --lib
Mainly adds some
#[cfg(feature = "sdk")]where it is possible or not to use io/fs, or prevent sending to std withjson_pretty_printand returning deploysChanges the way secret key is loaded in
with_payment_and_session()Publicizes some methods outside the crate
Adds
session_bytestosession_executable_deploy_item()and addscheck_no_conflicting_arg_types()(might require additional unit tests)Adds
with_bytes()toSessionStrParamsAdds some
Cloneattributes to some structsRemoves rt-multi-thread,
The default runtime flavor is 'multi_thread', but the 'rt-multi-thread' feature is disabled.switching (flavor = "current_thread") to tokio main. Please check this change is legit.Had an issue with schemars, I had to fix the version to "=0.8.5" apparently with Casper node 1.6.
For simplicity for now keeping new get_maybe_secret_key() as one function and not two as per previous PR for 2.0
casper-ecosystem/rustSDK#4
casper-ecosystem/rustSDK#5
casper-ecosystem/rustSDK#13