-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposition of changes into Casper Types to support a Rust SDK for 1.6 #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, for the sake of expediency in getting this out for 1.6, these changes are fine. However, I want to push for scheduling work for 2.0 to make this an additive feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to resolve the issue mentioned in my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
This PR intends to pull changes made for the Rust SDK. It is adding a
std-fs-io
default feature and affects several methods or expose them accordingly to be able to compile the client withThis PR has a strong dependency on PR against node 1.6 casper-network/casper-node#4348
Mainly adds some
#[cfg(feature = "std-fs-io")]
where it is possible or not to use io/fs, or prevent sending to std withjson_pretty_print
and returning deploysChanges the way secret key is loaded in
with_payment_and_session()
Publicizes some methods outside the crate
Adds
session_bytes
tosession_executable_deploy_item()
and addscheck_no_conflicting_arg_types()
(might require additional unit tests)Adds
with_bytes()
toSessionStrParams
Adds some
Clone
attributes to some structsRemoves rt-multi-thread,
The default runtime flavor is 'multi_thread', but the 'rt-multi-thread' feature is disabled.
switching (flavor = "current_thread") to tokio main. Please check this change is legit.For simplicity for now keeping new get_maybe_secret_key() as one function and not two as per previous PR for 2.0
casper-ecosystem/rustSDK#4
casper-ecosystem/rustSDK#5
casper-ecosystem/rustSDK#13