1.1 #113
Merged
1.1 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRoussac
approved these changes
Feb 7, 2024
|
|
||
| pub fn install_contract() { | ||
| let name: String = runtime::get_named_arg(NAME); | ||
| let previous_contract_version = runtime::get_key(&format!("{CONTRACT_NAME_PREFIX}{name}")) |
There was a problem hiding this comment.
Hi, would you mind changing the name of that var to previous_contract_hash ? because it is not a numerical version as the other contract_version
| .into_t() | ||
| .unwrap(); | ||
|
|
||
| let install_request_1 = ExecuteRequestBuilder::standard( |
There was a problem hiding this comment.
I guess you mean upgrade_request or upgrade_request_1 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add migration so users can make use of the new Peregrine cost table. Closes #112