Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR SDK Rust/Wasm #21

Closed
wants to merge 202 commits into from
Closed

Draft PR SDK Rust/Wasm #21

wants to merge 202 commits into from

Conversation

gRoussac
Copy link
Collaborator

Draft PR N#3

@deuszex
Copy link

deuszex commented Sep 21, 2023

Yeah once we move to feature PRs lets do it without the generated files on commit.

@gRoussac gRoussac requested a review from deuszex September 21, 2023 14:59
@hoffmannjan
Copy link

Yeah once we move to feature PRs lets do it without the generated files on commit.

we can generate then on the fly right? I mean as a part of CI pipeline, same as in js-sdk repo

@gRoussac
Copy link
Collaborator Author

Yeah once we move to feature PRs lets do it without the generated files on commit.

we can generate then on the fly right? I mean as a part of CI pipeline, same as in js-sdk repo

@deuszex @hoffmannjan

Yes please I am not very in my comfortable zone at CI/CD, the best I could make was a Makefile https://github.com/casper-ecosystem/rustSDK/blob/dev/Makefile#L23 please help I want cargo doc and typedoc to be executed so that I have the folder docs/api-wasm and docs/api-rust being linked in the Readme files wich is for now pointing to docs folders.

@deuszex
Copy link

deuszex commented Sep 21, 2023

Don't worry, we'll sort it out.

Copy link

@bpr bpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gRoussac
Copy link
Collaborator Author

gRoussac commented Oct 4, 2023

@bpr @RBYGLLS I am closing this PR in favor of branch dev-1.6 so that we make a main out of 1.6 and not 2.0 that remains in dev branch. Will re-open the same PR for 1.6.

@gRoussac gRoussac closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants