GH-5039: Tweak costs and chainspec settings #5047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapierski
requested review from
zajko,
darthsiroftardis,
EdHastingsCasperAssociation and
igor-casper
| let entry_point = match footprint.entry_points().get(entry_point_name) { | ||
| Some(entry_point) => entry_point, | ||
| None => { | ||
| match footprint.entity_kind() { |
There was a problem hiding this comment.
nit couldn't this be if let EntityKind::System(_) = ?
Comment on lines
+3286
to
+3293
|
|
||
| let cost = match fixture.chainspec.core_config.pricing_handling { | ||
| PricingHandling::Classic => 0, | ||
| PricingHandling::Fixed => { | ||
| fixture.chainspec.system_costs_config.mint_costs().transfer * (current_gas_price as u32) | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
I don't understand why Classic is set to 0 here...in classic pricing the imputed amount should be used and 0 is not a valid imputed amount
EdHastingsCasperAssociation
approved these changes
Dec 20, 2024
|
bors r+ |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Dec 20, 2024
5047: GH-5039: Tweak costs and chainspec settings r=EdHastingsCasperAssociation a=mpapierski Closes #5039 This PR adds a gas charge for calling a non-existing system contract entry point. Additionally, some charges for incorrectly charged system contract entrypoints are raised significantly (10k motes -> 2.5 CSPR or more depending on complexity). This PR changes `fee_handling` and `refund_handling` to be consistent with 1.5.x settings (refund 99% and pay to proposer) Co-authored-by: Michał Papierski <[email protected]> Co-authored-by: edhastings <[email protected]>
|
Build failed: |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Dec 21, 2024
5048: GH-5039: Tweak costs and chainspec settings r=EdHastingsCasperAssociation a=EdHastingsCasperAssociation Closes #5039 This PR adds a gas charge for calling a non-existing system contract entry point. Additionally, some charges for incorrectly charged system contract entrypoints are raised significantly (10k motes -> 2.5 CSPR or more depending on complexity). This PR changes fee_handling and refund_handling to be consistent with 1.5.x settings (refund 99% and pay to proposer) #5047 Co-authored-by: Michał Papierski <[email protected]> Co-authored-by: Ed Hastings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5039
This PR adds a gas charge for calling a non-existing system contract entry point. Additionally, some charges for incorrectly charged system contract entrypoints are raised significantly (10k motes -> 2.5 CSPR or more depending on complexity).
This PR changes
fee_handlingandrefund_handlingto be consistent with 1.5.x settings (refund 99% and pay to proposer)