Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account_put_deploy example to work with current casper-node #1294

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

jacek-casper
Copy link
Contributor

What does this PR fix/introduce?

It changes the account_put_deploy example slightly to pass validation on the current dev version of casper-node.

Additional context

When on-boarding I was trying it examples in the docs and I noticed a few issues:

  • the amount in the example is I32, but that seems to be disallowed in casper-node, leading to an error failed to parse transfer 'amount' as U512
  • the Transfer object doesn't have a target, which is currently also rejected in casper-node: missing transfer 'target' runtime argument
  • casper-node currently enforces a minimal transfer amount of 2500000000, so I've set the amount to that as well

Checklist

(Delete any that aren't relevant)

  • Docs are successfully building - yarn install && yarn run build.

Reviewers

Copy link
Contributor

@ACStone-MTS ACStone-MTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ACStone-MTS ACStone-MTS merged commit fdbc77f into casper-network:dev Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants