Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Prevent disallowed conversions between object and by-ref-like parameter and return types #665

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
+363 −35
Draft

Draft: Prevent disallowed conversions between object and by-ref-like parameter and return types #665

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
904397f
New cond. compilation symbol `FEATURE_BYREFLIKE`
stakx Sep 3, 2023
375fe40
Add failing tests for by-ref-like types
stakx Sep 3, 2023
d99a22f
Avoid `object` <-> by-ref-like type conversions
stakx Sep 3, 2023
f61fad5
`Type.IsByRefLike` is not always implemented
stakx Sep 3, 2023
9f72f39
Update changelog
stakx Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update changelog
@stakx
stakx committed Sep 3, 2023
commit 9f72f39e9ea8ad6453552b9e624fc448f0443342
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -5,8 +5,10 @@
Enhancements:
- Two new generic method overloads `proxyGenerator.CreateClassProxy<TClass>([options], constructorArguments, interceptors)` (@backstromjoel, #636)
- Allow specifying which attributes should always be copied to proxy class by adding attribute type to `AttributesToAlwaysReplicate`. Previously only non-inherited, with `Inherited=false`, attributes were copied. (@shoaibshakeel381, #633)
- Minimally improved support for methods having `ref struct` parameter and return types such as `Span<T>`: Intercepting such methods caused the runtime to throw `InvalidProgramException` and `NullReferenceException` due to forbidden conversions of `ref struct` values when transferring them into & out of `IInvocation` instances. To prevent these exceptions from being thrown, such values now get replaced with `null` in `IInvocation`, and with `default` values in return values and `out` arguments. (@stakx, #665)

Bugfixes:
- `InvalidProgramException` when proxying `MemoryStream` with .NET 7 (@stakx, #651)
- `ArgumentException`: "Could not find method overriding method" with overridden class method having generic by-ref parameter (@stakx, #657)
- `ArgumentException`: "Cannot create an instance of `TEnum` because `Type.ContainsGenericParameters` is true" caused by `Enum` constraint on method `out` parameter (@stakx, #658)