- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31
 
          SortedRecordingConverter for solving unit electrode provenance in sorted data
          #1132
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SortedRecordingConverter for solving unit electrode provenance
      SortedRecordingConverter for solving unit electrode provenanceSortedRecordingConverter for solving unit electrode provenance in sorted data
      | 
           OK, so we can have this as a base for the manual case. In another PR coming after this we can use sortinganalyzer tools to automatically build the mapping on the fly. After that, let's think on an interface that will generalize this to converters with multiple interfaces. @alejoe91 can you take a look at this? I will add the sorting_analyzer automatic detection in a future PR later.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @h-mayorquin
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   90.40%   90.32%   -0.09%     
==========================================
  Files         133      136       +3     
  Lines        8511     8616     +105     
==========================================
+ Hits         7694     7782      +88     
- Misses        817      834      +17     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
  | 
    
This has #1124 as a base and should be done after that.
This converter can be used to write sorted data and keep the correct electrode provenance of the units (display electrodes in the units table). The converted takes care of handling the correct map between units and electrodes which is important for multiple recording/probes such as the one discussed in #1112.
Also related to this:
#961