- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31
 
Add GeneralTiffImagingInterface for MultiTiffMultiPageExtractor #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add GeneralTiffImagingInterface for MultiTiffMultiPageExtractor #1457
Conversation
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   87.11%   87.05%   -0.06%     
==========================================
  Files         147      147              
  Lines        9746     9766      +20     
==========================================
+ Hits         8490     8502      +12     
- Misses       1256     1264       +8     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
  | 
    
| num_acquisition_cycles=num_acquisition_cycles, | ||
| verbose=verbose, | ||
| ) | ||
| self.imaging_extractor.get_num_channels = lambda: 1 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this now that:
has been merged.
You can also point to the main branch of roiextractors pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also point to the main branch of roiextractors pyproject.toml
Not sure what you mean by this, the neuroconv pyproject points to the main branch already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 
           I was busy last week so now I am back on the trenches. Are you still interested in moving forward with this PR? If so, here's what we can do next: 
 
 We can deprecate the  
 These should go into: 
 I'm happy to take this to the finish line, but if you have the time and interest, it would be great to have you work on this. It's always valuable to have external contributors involved, though I would understand if you are busy.  | 
    

A more general
tiffinterface that utilizes the newroiextractors.MultiTIFFMultiPageExtractorfrom catalystneuro/roiextractors#402