support slotinfo 244 (#73)

* support slotinfo 244 Signed-off-by: catcherwong <[email protected]> * fix slot info Signed-off-by: catcherwong <[email protected]> * remove useless code Signed-off-by: catcherwong <[email protected]> --------- Signed-off-by: catcherwong <[email protected]>
catcherwong · Oct 6, 2024 · 8a8ab76 · 8a8ab76
1 parent 702d263
commit 8a8ab76
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 0 deletions.
diff --git a/src/RDBParser/BinaryReaderRDBParser.cs b/src/RDBParser/BinaryReaderRDBParser.cs
@@ -17,6 +17,7 @@ public partial class BinaryReaderRDBParser : IRDBParser
         private int _freq = 0;
         private int _mem_policy = -1; // 1 - lru | 2 - lfu
         private int _version = -1;
+        private ulong _slotId = 0;
         private HashSet<string> _auxKey = new HashSet<string>();
 
         public BinaryReaderRDBParser(IReaderCallback callback, ParserFilter filter = null)
@@ -88,6 +89,19 @@ public void Parse(string path)
                             }
                         }
 
+                        if (opType == Constant.OpCode.SLOTINFO)
+                        {
+                            // cluster keyslot yourkey
+                            _slotId = br.ReadLength();
+
+                            // slotSize
+                            _ = br.ReadLength();
+
+                            // expireSlotSize
+                            _ = br.ReadLength();
+                            continue;
+                        }
+
                         if (opType == Constant.OpCode.SELECTDB)
                         {
                             if (!isFirstDb)
@@ -174,6 +188,7 @@ public void Parse(string path)
                             {
                                 info.Idle = _idle;
                                 info.Freq = _freq;
+                                info.SlotId = _slotId;
 
                                 ReadObject(br, _key, opType, _expiry, info);
                             }

diff --git a/src/RDBParser/Callbacks/Models/Info.cs b/src/RDBParser/Callbacks/Models/Info.cs
@@ -12,6 +12,8 @@ public class Info
 
         public ulong Zips { get; set; }
 
+        public ulong SlotId { get; set; }
+
         public override string ToString()
         {
             return $"Info{{Encoding={Encoding},Idle={Idle},Freq={Freq},SizeOfValue={SizeOfValue},Zips={Zips}}}";

diff --git a/src/RDBParser/Constant.cs b/src/RDBParser/Constant.cs
@@ -31,6 +31,10 @@ public static class MagicCount
 
         public static class OpCode
         {
+            /// <summary>
+            /// Individual slot info, such as slot id and size (cluster mode only).
+            /// </summary>
+            public const int SLOTINFO = 244;
             public const int FUNCTION2 = 245;
             public const int FUNCTION = 246;
             public const int MODULE_AUX = 247;

diff --git a/tests/RDBParserTests/ClusterTests.cs b/tests/RDBParserTests/ClusterTests.cs
@@ -0,0 +1,35 @@
+using RDBParser;
+using System.Text;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace RDBParserTests
+{
+    public class ClusterTests
+    {
+        private ITestOutputHelper _output;
+
+        public ClusterTests(ITestOutputHelper output)
+        {
+            this._output = output;
+        }
+
+        [Fact]
+        public void TestSoltInfo()
+        {
+            // set key{v1} v1
+            // set key{v12} v12
+            // bgsave
+            var path = TestHelper.GetRDBPath("redis74_cluster_slotinfo.rdb");
+
+            var callback = new TestReaderCallback(_output);
+            var parser = new BinaryReaderRDBParser(callback);
+            parser.Parse(path);
+
+            var infos = callback.GetInfos();
+
+            Assert.Equal(1165, (int)infos[0][Encoding.UTF8.GetBytes("key{v1}")].SlotId);
+            Assert.Equal(2589, (int)infos[0][Encoding.UTF8.GetBytes("key{v12}")].SlotId);
+        }
+    }
+}
diff --git a/tests/dumps/redis74_cluster_slotinfo.rdb b/tests/dumps/redis74_cluster_slotinfo.rdb