Skip to content

Commit

Permalink
Merge pull request #141 from wendellmeset/patch-2
Browse files Browse the repository at this point in the history
Fixed some minor optimization issues in the click manager/handler.
  • Loading branch information
kylerchin authored Feb 11, 2025
2 parents 91b925b + edb49f9 commit 4c40bd7
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions src/components/mapClickHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,20 @@ export function setup_click_handler(
layerspercategory: Record<string, any>,
setSidebarOpen: () => void
) {
map.on('click', (e) => {
console.log('clicked on ', e);
// Precompute interactive layers array
const interactiveLayers = Object.values(layerspercategory)
.flatMap((category) => Object.values(category))
.filter(Boolean);

const click_bbox: [maplibregl.PointLike, maplibregl.PointLike] = [
map.on('click', (e) => {
const clickBbox: [maplibregl.PointLike, maplibregl.PointLike] = [
[e.point.x - 5, e.point.y - 5],
[e.point.x + 5, e.point.y + 5]
];

try {
const selectedFeatures = map.queryRenderedFeatures(click_bbox, {
layers: Object.values(layerspercategory)
.map((x) => Object.values(x))
.flat()
});

console.log('selectedFeatures', selectedFeatures);
const selectedFeatures = map.queryRenderedFeatures(clickBbox, { layers: interactiveLayers });
// console.log('selectedFeatures', selectedFeatures);

const selected_vehicles_raw = selectedFeatures.filter(
(x: Record<string, any>) =>
Expand Down Expand Up @@ -117,7 +115,7 @@ export function setup_click_handler(
})
.filter((x: MapSelectionOption | null) => x != null);

console.log('selected shapes', selected_routes_raw);
// console.log('selected shapes', selected_routes_raw);

let MapSelectionOptions = new Array<MapSelectionOption>();

Expand All @@ -138,7 +136,7 @@ export function setup_click_handler(
);
}

console.log('data stack now', get(data_stack_store));
// console.log('data stack now', get(data_stack_store));
on_sidebar_trigger_store.update((x) => x + 1);

setSidebarOpen();
Expand Down

0 comments on commit 4c40bd7

Please sign in to comment.