-
-
Notifications
You must be signed in to change notification settings - Fork 188
feat(google-account): init #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ~2000 or so lines theming autogenerated classes are giving me hesitation on this one. We've been trying to reduce the number of new userstyles with unmaintainable autogenerated classnames and this isn't helping. If the variables aren't theming everything... it's unfortunate.
I left a lot of comments regarding the scope of each variable, so it would be easy to split out things if we wanted to narrow the scope of the userstyle for better long term maintainability. Google One is the most generated class intensive product, and the legacy M1/M2 components are the second most generated class intensive product. Things like the login screen have been almost 100% migrated over to gm3/mdc, where very small amounts of generated classes only power things like the language selector dropdown menu. I think I left some comments regarding this in the code, but the base Google Account hub is in the middle of a transition to gm3/mdc, where a lot of things that were previously legacy generated classes are moving over to using CSS variables for dark theme support. That's why this PR is a draft: I'd like to wait a few months to see what state Google Account and the related products are in by then, so that a lot of the legacy code could be potentially removed. |
Gotcha. If you want to, if any whole pages out of the bunch this PR aims to theme is full covered by the variables, you could pull them out and I'd be happy to merge that separately and leave a followup draft PR to wait for the migrations and whatnot you mention. |
Got it! I was thinking of splitting the Google login page out, and maybe the Google account dropdown out, would that work as a seperate userstyle (google-login)? |
Those feel like things that should be part of the existing |
Google I feel should be refactored into Google Search, and we should have a user style for Google (Core?) that will contain code with reused across all Google products. That seems like the best way to solve all the scattered code and multiple userstyles theming the same common shared components. |
It is slightly awkward because renaming userstyles is not very ergonomic. I guess it is slightly different because the userstyle would still be functional just for a different purpose, and we could open a pinned issue directing people to a new google-search userstyle... I'll think about it. In the mean time I'll let you continue your work on this :) |
I've decided ogs should have it's home in the google userstyle for the meantime: I will make a PR for all the improvements I've made to ogs codebase to the Google userstyle. |
09670a5
to
ecbce8b
Compare
🎉 Theme for Google Account, Google Account, Google One, Google My Ad Center 🎉
Google Account is the account management hub of the Google Workspace suite. It is used for login, authentication, and the such. Google One is another hub of the Google Workspace suite, for storage, Gemini, choosing Google Workspace plans. Google My Ad Center is a center where personalized ads can be personalized, and where you can turn off unwanted sensitive content see ad.
Google Account catwalk
Google One catwalk
Google Login catwalk
💬 Additional Comments 💬
A lot of stuff, the generated class lists everywhere on Google One were main thing.
Make sure to review how apps inject into the ogs.google.com account popup, like google search and google drive. Make sure the PFP customizer works everywhere, including from products like Google Classroom, and Google Maps.
Google ogs is automatically generated from a deno script I wrote and is just manually fixed up to fit the linter by me.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.catppuccin.user.less
- all the CSS for the userstyle, based on the template.preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.