Skip to content

refactor(google-photos): integrate m3 lib module #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: feat/m3-lib
Choose a base branch
from
Open

refactor(google-photos): integrate m3 lib module #1877

wants to merge 27 commits into from
+29 −442

Conversation

WalkQuackBack
Copy link
Member

@WalkQuackBack WalkQuackBack commented Sep 1, 2025 •
edited
Loading

🔧 What does this fix? 🔧

refactor Google Photos to use M3 lib

🗒 Checklist 🗒

@github-actions github-actions bot added the google-photos Google Photos label Sep 1, 2025
WalkQuackBack
WalkQuackBack commented Sep 3, 2025
View reviewed changes
WalkQuackBack
WalkQuackBack commented Sep 3, 2025
View reviewed changes
@uncenter uncenter changed the title Refactor/m3 lib integrate photos refactor(google-photos): integrate m3 lib module Sep 5, 2025
@WalkQuackBack
Copy link
Member Author

Lint is passing now that #1846 has been merged to main.

@WalkQuackBack WalkQuackBack marked this pull request as ready for review September 6, 2025 18:37
uncenter
uncenter reviewed Sep 6, 2025
View reviewed changes
uncenter
uncenter reviewed Sep 7, 2025
View reviewed changes
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me yeah. Noting that this will not be merged until the M3 lib is finalized and merged itself.

AlwaysNur
AlwaysNur reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@AlwaysNur AlwaysNur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like image here is unthemed:

photos.google.com/unsupported Image file is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter left review comments

@GenShibe GenShibe Awaiting requested review from GenShibe GenShibe is a code owner

+1 more reviewer

@AlwaysNur AlwaysNur AlwaysNur left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
google-photos Google Photos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalkQuackBack @uncenter @AlwaysNur