Skip to content

Conversation

zenoix
Copy link
Contributor

@zenoix zenoix commented Sep 8, 2025

🔧 What does this fix? 🔧

This pull request aims to theme the following from #1891:

  • Hamburger menu icon
  • Hamburger menu headers/sections
  • Settings menu item hovers
  • Stockfish configuration buttons
  • Sign in, register page (input borders, sign in button)
  • Preference options
  • Game selector on main page

Additionally:

  • Settings menu sub-menu items (except sliders feat(lichess): unthemed UI elements #1897 (comment))
  • Top bar gradient when the page is slightly scrolled down
  • Button selectors for play with the computer
  • Unthemed running clock
  • Invite friend to game (and most likely the received invitation page)
  • Main page tournament progress bars
  • Analysis eval bar

Screenshots:

image image image image image image image image image image image image image image image

🗒 Checklist 🗒

@zenoix zenoix linked an issue Sep 8, 2025 that may be closed by this pull request
7 tasks
@github-actions github-actions bot added the lichess Lichess label Sep 8, 2025
@zenoix
Copy link
Contributor Author

zenoix commented Sep 10, 2025

I can't figure out how to style the input sliders in the settings menu so if anyone knows how, let me know or feel free to implement it :)

@uncenter
Copy link
Member

I can't figure out how to style the input sliders in the settings menu so if anyone knows how, let me know or feel free to implement it :)

What are you referring to?

@zenoix
Copy link
Contributor Author

zenoix commented Sep 10, 2025

What are you referring to?

These sliders:
image
image

@uncenter
Copy link
Member

Oh yeah native range sliders are terrible to theme. You can set the accent-color bit but the rest is not worth it.

@zenoix
Copy link
Contributor Author

zenoix commented Sep 10, 2025

rip

@zenoix
Copy link
Contributor Author

zenoix commented Sep 10, 2025

@uncenter Is there a way to style elements that are styled inline? In the registration page, the password complexity bar has spans that get directly styled when the password complexity increases:
image

@uncenter
Copy link
Member

.password-complexity-meter {
  [style="background-color: red;"] {
    background-color: @red !important;
  }
}

Note the !important to override the inline styles.

@zenoix
Copy link
Contributor Author

zenoix commented Sep 10, 2025

.password-complexity-meter {
  [style="background-color: red;"] {
    background-color: @red !important;
  }
}

Note the !important to override the inline styles.

Sick! Thanks for that. Learning something new every day lol

@zenoix
Copy link
Contributor Author

zenoix commented Sep 12, 2025

I think this is enough changes for one pull request. Ready for review now :)

@zenoix zenoix marked this pull request as ready for review September 12, 2025 08:27
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile page has some unthemed areas:

CleanShot 2025-09-19 at 11 04 52

In yellow, the text contrast is poor. In red, we should use accent instead of red for the color of the current page in settings I think.

CleanShot 2025-09-19 at 11 05 31

@zenoix
Copy link
Contributor Author

zenoix commented Sep 20, 2025

@uncenter

In regards to the profile section and the preference's contrasts, it seems like Lichess updated some of their UI since this PR was opened. For example, now this is no longer themed as it has been updated:
image
I guess I'll have to convert this issue back into a draft to fix any changed UI I find.


we should use accent instead of red for the color of the current page in settings I think.

This was already set to red when I started working on the Lichess theming so I assume it was approved to be red (I did find it a bit strange tho). Happy to change the red to accent if that's preferred :)

@zenoix
Copy link
Contributor Author

zenoix commented Sep 20, 2025

Fixed the create game menus
image

@zenoix
Copy link
Contributor Author

zenoix commented Sep 20, 2025

This was already set to red when I started working on the Lichess theming

Changed

image image

@zenoix
Copy link
Contributor Author

zenoix commented Sep 20, 2025

In yellow, the text contrast is poor.

Okay, for this it seems like I trolled. Not sure how I didn't notice it regressing but I fixed it, apologies!

image

@zenoix
Copy link
Contributor Author

zenoix commented Sep 20, 2025

Also themed the puzzle dashboard page (bottom visualisation is a canvas and not sure if it's possible to style those):
image

@zenoix zenoix requested a review from uncenter September 21, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lichess Lichess
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lichess unthemed UI elements
2 participants