Fix study detail logic to allow access without login

caulipse · Jun 5, 2022 · f6a2520 · f6a2520
1 parent 5500cec
commit f6a2520
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/routes/study/study.controller.ts b/src/routes/study/study.controller.ts
@@ -273,13 +273,15 @@ const getStudybyId = async (req: Request, res: Response) => {
           applied: appliedFlag ? true : false,
         });
       } catch (e) {
-        res.status(200).json({ ...study, bookmarked: false, applied: false });
+        return res
+          .status(200)
+          .json({ ...study, bookmarked: false, applied: false });
       }
-    } else {
-      return res
-        .status(200)
-        .json({ ...study, bookmarked: false, applied: false });
     }
+
+    return res
+      .status(200)
+      .json({ ...study, bookmarked: false, applied: false });
   } catch (e) {
     if ((e as Error).message === NOT_FOUND) {
       return res.status(404).json({ message: NOT_FOUND });