To infinity and Beyond! #70
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cb341
commented
Jan 26, 2026
cb341
commented
- Infinite terrain generation
- Dynamic terrain loading opposed to only loading on startup
Problematic as there isn't a list of chunks that have already requested by the client meaning that when the player is moving too quickly chunks get requested too often and it causes issues. this should be handled by the client. the server should allow clients to rerequest chunks they already requested
cb341
commented
Jan 28, 2026
| let mut next_state_value = current_state_value.clone(); | ||
|
|
||
| if *current_state_value == GameState::WaitingForServer || *current_state_value == GameState::LoadingSpawnArea { | ||
| // TODO: Introduce Chatting Substate |
Owner
Author
There was a problem hiding this comment.
This will be implemented in a follow up PR alongside a rework of events
cb341
commented
Jan 28, 2026
| next_state.set(GameState::Playing); | ||
| } | ||
|
|
||
| next_state.set(next_state_value); |
Owner
Author
There was a problem hiding this comment.
This one was annoying to catch. it wasn't possible to transition from WorldLoading to Playing.
- world loading check system sets next state to Playing after realizing that the world is loaded
- same tick, this system overrides the next state with the current state
- world never enters playing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.