Fix config field validation and build for Statamic 6#1
Merged
Conversation
Update ReverseRelationshipFieldSelect to emit 'update:value' instead of the Vue 2 'input' event, matching Statamic 6's Fieldtype API. This fixes the config panel sending field: null despite user input. Also update the @statamic/cms package path from the old dist-package location to packages/cms, fixing npm run build on fresh installs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Apply Pint auto-fixes (ordered imports, strict types, unary operators). Fix tag tests by passing trusted=true to Antlers::parse(), required in Statamic 6 for tag execution outside of Blade templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReverseRelationshipFieldSelectemitted'input'(Vue 2 pattern) instead of'update:value'(Statamic 6 Fieldtype API). This causedfield: nullto be sent in the config payload despite the user selecting or typing a value, triggering a "This field is required" validation error on save.@statamic/cmsdependency inpackage.jsonpointed to the old Statamic 5 path (resources/dist-package). Updated to the Statamic 6 path (packages/cms), sonpm run buildworks aftercomposer install.resources/dist/so the fixes ship with the package via Composer without requiring end users to runnpm run build.Test plan
composer install+npm run buildcompletes without errors