-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature bipolar references #173
base: main
Are you sure you want to change the base?
Conversation
Thanks for your PR! Would you mind splitting it up so that one PR tackles exactly one issue? Regarding the arguments, can you explain the issue with the current implementation and how your fix works? Regarding the bipolar reference feature, currently you hard-code the derivations, but I'd prefer that the user decides which channels are anodes and which channels are cathodes. Based on this input, custom bipolar derivations could be computed. Let me know what you think and if you need help implementing these changes! |
Yes ok I'll split in 2 PR.
I will explain in the specific new PR (and add a specific issue also)
I agree with you. Also maybe add a load/save button to create bipolar reference profile (to avoid setting every time)
|
8b773e8
to
5f6ce4a
Compare
@cbrnr (@Qdelannoy) I updated this PR to select the channels via a dialog, you can give it a try ? |
[updated]