Move PTAXSIM DB file to runner temp dir #36
Conversation
dfsnow
changed the title
| @@ -13,7 +13,7 @@ knitr::opts_chunk$set( | |||
|
|
|||
| # Introduction | |||
|
|
|||
| Property tax exemptions are savings that lower a homeowner’s property tax bill. They work by reducing or freezing the taxable value (Equalized Assessed Value, or EAV) of a home. For example, the most common exemption, the Homeowner Exemption, reduces EAV by \$10,000. | |||
There was a problem hiding this comment.
This stuff is just extraneous cleanup from my built-in linter/fixers.
| ```{r, echo=FALSE} | ||
| # This is needed to build the vignette using GitHub Actions | ||
| ptaxsim_db_conn <- DBI::dbConnect( | ||
| RSQLite::SQLite(), | ||
| Sys.getenv("PTAXSIM_DB_PATH") | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Vignettes need to point at the temp directory during build time, but I don't necessarily want to use the env var setup here since it's a bit confusing.
| # This is needed to build the vignette using GitHub Actions | ||
| ptaxsim_db_conn <- DBI::dbConnect( | ||
| RSQLite::SQLite(), | ||
| Sys.getenv("PTAXSIM_DB_PATH") | ||
| ) |
There was a problem hiding this comment.
[Question, non-blocking] What's the relationship between this DBI::dbConnect() call and the one that precedes it on line 50? Is the idea just that this will overwrite the preceding ptaxsim_db_conn definition on CI, but locally we can skip this call and use the one on line 50 instead?
There was a problem hiding this comment.
You got it. This call is hidden in the actual output vignette HTML just because I think it's simpler to show a file path instead of an env var setup, but the env var is necessary for it to work on CI.
This PR fixes two bugs related to our PTAXSIM CI integration. Mainly:
NaNtax rate (divide by 0 error). I added a line to replaceNaNvalues with 0 and added a test to catch future issues of the same nature.