Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zero args Function handler #44

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Conversation

ccfontes
Copy link
Owner

No description provided.

@ccfontes ccfontes changed the title Add no args handler e2e Function example Support no args e2e Function example Dec 16, 2023
…template documentation

refactor(examples/potd): add docstring to handler function for clarity

refactor(template/bb): introduce wrap-arg function to handle functions with different arity

test(template/bb): add tests for new wrap-arg function and fn-arg-cnt utility

feat(examples/stack.yml): update image name to include language prefix for clarity

The changes include documentation updates to clarify the requirements for the handler function in the template, a refactor to support handler functions with different numbers of arguments, and additional tests to ensure the new functionality works as expected. The image name in the example stack configuration is also updated to be more descriptive.
ci: remove potd function definition from stack.yml

The changes remove the 'potd' service and its associated steps from the GitHub Actions workflow and the stack configuration. This is likely because the 'potd' service is no longer needed or has been deprecated.
feat(examples): add .gitignore to exclude common directories
refactor(examples): remove bb-hiccup function from stack.yml configuration
feat(stack.yml): register bb-hiccup and potd functions in stack configuration
refactor(template/bb/index.clj): use thread macro for fn-arg-cnt definition for better readability
test(template/bb/tests.clj): add test case for function with no arglists in index.clj
@ccfontes ccfontes changed the title Support no args e2e Function example Support zero args Function handler Dec 18, 2023
…r name

refactor(ci): remove quotes around numeric comparison in if condition for consistency
- Use underscore in variable name for consistency
- Quote variable expansion to ensure string length check works correctly
…ons workflow

The change fixes a syntax error in the shell conditional expression by removing the unnecessary `echo` command, ensuring the string length check for `bb_potd` is performed correctly.
@ccfontes ccfontes merged commit 28de2ab into main Dec 18, 2023
8 checks passed
@ccfontes ccfontes deleted the add_no_args_handler_e2e_example branch December 18, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant