Open
Conversation
|
I'm using this fork for my own project (and will add/fix anything beyond the work you've done), just wanted to say thanks and respect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time using this gem and as I started using it, discovered bars endpoint was still on v1, which no longer exists.
There seems to be a lot of forward changes on the Alpaca endpoint since the bars endpoint was originally written, so this is a bit of a breaking change as well by introducing keyword arguments for all params.
Notes:
:tradesand:weighted_average_priceproperties.Time.atchanged toTime.parseon theBarclass.timeframemethod argument now a keyword argument (breaking change). Now optional and defaults to'1D'symbolsmethod argument now keyword argument (breaking change). Can accept a string for single symbol lookup.asofoptional parameter needed if desiring to look upFBorMETAcorrectly (see API docs). Defers to API when omitted.feedoptional parameter to modify source of data feed for the symbols. Defaults to'sip'start_dateoptional parameter to set the starting date for historical feed. Defers to API when omitted.end_dateoptional parameter to set the ending date for historical feed. Defers to API when omitted.focus: truewhen focusing on specific specs.There are some pre-existing failing specs unrelated to changes to
barswhich I did not address.