Skip to content

Raise 400 responses as an InvalidRequest #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benterova wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raise 400 responses as an InvalidRequest #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/alpaca/trade/api/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def close_positions

def last_trade(symbol:)
response = get_request(data_endpoint, "v1/last/stocks/#{symbol}")
raise InvalidRequest, JSON.parse(response.body)['message'] if response.status == 404
raise InvalidRequest, JSON.parse(response.body)['message'] if [404, 400].include?(response.status)

LastTrade.new(JSON.parse(response.body))
end
Expand All @@ -138,6 +138,7 @@ def new_order(symbol:, side:, type:, time_in_force:, qty: nil, notional: nil,
response = post_request(endpoint, 'v2/orders', params.compact)
raise InsufficientFunds, JSON.parse(response.body)['message'] if response.status == 403
raise MissingParameters, JSON.parse(response.body)['message'] if response.status == 422
raise InvalidRequest, JSON.parse(response.body)['message'] if response.status == 400

Order.new(JSON.parse(response.body))
end
Expand Down Expand Up @@ -182,7 +183,7 @@ def replace_order(id:, qty: nil, time_in_force: nil, limit_price: nil,
response = patch_request(endpoint, "v2/orders/#{id}", params.compact)
raise InsufficientFunds, JSON.parse(response.body)['message'] if response.status == 403
raise InvalidOrderId, JSON.parse(response.body)['message'] if response.status == 404
raise InvalidRequest, JSON.parse(response.body)['message'] if response.status == 422
raise InvalidRequest, JSON.parse(response.body)['message'] if [400, 422].include?(response.status)

Order.new(JSON.parse(response.body))
end
Expand Down