Git source control: added an optional 'revision' configuration property

[JoseMarcenaro]

In cases where the CCNET tool is used to manually launch a test or release build, and Git source control is used, it would be helpful to specify - with a dynamic parameter - a specific revision (tag name, or even commit hash) to checkout and build.

This proposed patch is an update of the existing Git.cs class (and its unit test) implementing this feature as an added 'revision' configuration element (optional, default empty)

This feature addresses the same need described by Scott Vercuski 2 months ago in this entry

[dnauck]

Hi,

is it really needed to add a second property that is nearly the same as the branchproperty?
Have you tested to specify your tag in the branch property? It should work, too.

[savornicesei]

Hi @JoseMarcenaro @dnauck @RubenWillems @mintsoft
IMHO this should not be merged.

I've been looking for the past 2 days at how CC.NET and Jenkins implemented Git as source control and Git support in CC.NET is pretty rudimentary (10yrs ago SVN was ruling the Earth 😄 ).
CC.NET should detect if given branch name is a branch, a tag, a commit that's not a HEAD and do the proper checkout (see issue #273 ).

Best,
Simo

[JoseMarcenaro]

Hi @savornicesei

Yes, that would be a better implementation. I agree.
Seven years ago I coded this 'revision' feature as a workaround for a specific need, but the proposed solution is better.

Regards,
Jose

[linquize]

Could you rebase onto latest master?

[RubenWillems]

Hi I'm not that familiar with GIT but I know a Rebase has the option to destroy the repo. what would the correct syntax be? And what would you like for the outcome? what will the rebase solve? grts Ruben

…

On Sat, 24 Aug 2019 at 18:25, linquize ***@***.***> wrote: Could you rebase onto latest master? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163?email_source=notifications&email_token=AAEUZAKH7Y2RXJ4PGGG55ZLQGFOH7A5CNFSM4ABP6WDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CDIAY#issuecomment-524563459>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEUZAJPXZZY4A5PITXMR6DQGFOH7ANCNFSM4ABP6WDA> .

[mintsoft]

@RubenWillems I think what @linquize meant is that if @JoseMarcenaro rebases his fork from master, the conflicts will go away as @JoseMarcenaro will have to solve them when he rebases. Then we should be able to single-click-merge the PR on github as it'll be unconflicted

[RubenWillems]

Hi thanks for the update. That makes indeed a lot more sense. with kind regards Ruben Willems

…

On Mon, 26 Aug 2019 at 14:06, Rob Emery ***@***.***> wrote: @RubenWillems <https://github.com/RubenWillems> I think what @linquize <https://github.com/linquize> meant is that if @JoseMarcenaro <https://github.com/JoseMarcenaro> rebases his fork from master, the conflicts will go away as @JoseMarcenaro <https://github.com/JoseMarcenaro> will have to solve them when he rebases. Then we should be able to single-click-merge the PR on github — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163?email_source=notifications&email_token=AAEUZAMENA4BPA5KHWNJ563QGPBLRA5CNFSM4ABP6WDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EFKJA#issuecomment-524834084>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEUZANENWW5BJI6T3V7L23QGPBLRANCNFSM4ABP6WDA> .

[JoseMarcenaro]

Hi guys
It's been 7 years since I added this (proposed) feature in my branch, and the repository code has evolved a lot since.

I did a quick check of what the rebase would require, but there are many (27) conflics in the core Git.cs class.
I'm really not confortable with trying to solve the multiple conflicts in a code that I'm no longer using and will not be able to test thoroughly before committing.

If this PR code can inspire you to implement a similar feature on top of the current code, go ahead.

[mintsoft]

It's probably best to close this PR then @JoseMarcenaro we've got it for reference anyway :)