Skip to content

Stop attempting "legacy editable" installs#1070

Merged
dwpaley merged 3 commits into
masterfrom
xfel_revert_workaround
May 2, 2025
Merged

Stop attempting "legacy editable" installs#1070
dwpaley merged 3 commits into
masterfrom
xfel_revert_workaround

Conversation

@dwpaley
Copy link
Copy Markdown
Contributor

@dwpaley dwpaley commented May 1, 2025

Legacy-editable mode was removed in pypa/setuptools#4953, this env
variable no longer does anything. We accommodate the new behavior in
cctbx/dxtbx#807 and dials/dials#2906.

dwpaley added 3 commits April 30, 2025 18:10
Legacy-editable mode was removed in pypa/setuptools#4953, this env
variable no longer does anything. We accommodate the new behavior in
cctbx/dxtbx#807 and dials/dials#2906.
@dwpaley
Copy link
Copy Markdown
Contributor Author

dwpaley commented May 1, 2025

We can't get rid of legacy editable mode because some builders are pinned to previous versions of dials and dxtbx. Those old versions still expect (in libtbx_refresh.py) to have been installed in legacy editable mode, therefore they add e.g. modules/dials/src to the pythonpath instead of build/dials/lib/python3.x/site-packages. For those builders (at least cctbx and phenix) we will just have to keep setuptools <79 as long as the dials and dxtbx versions remain pinned. For this PR I'll just remove Aaron's workaround in the tests, and scrap the other part for the foreseeable.

@bkpoon
Copy link
Copy Markdown
Member

bkpoon commented May 1, 2025

We can bump up those versions to 3.22. That's the version that we're shipping with Phenix right now since it's the last version to support Python 3.9. The pinned versions in bootstrap.py are because those builders only need things to compile.

@dwpaley dwpaley merged commit 5757432 into master May 2, 2025
101 checks passed
@dwpaley dwpaley deleted the xfel_revert_workaround branch May 2, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants