UserApi Development Initialized #189
Conversation
I did the first endpoint, but I need the feedback. Also in the Mock test for the UserApi, I disabled the assertSent function as it gave me errors. Could you tell me what I did wrong? Thank you in advance.
src/test/java/com/cdancy/bitbucket/rest/features/UserApiMockTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/cdancy/bitbucket/rest/features/UserApiMockTest.java
Outdated
Show resolved
Hide resolved
| @Nullable @QueryParam("permission.1.projectId") String projProjectId, | ||
| @Nullable @QueryParam("permission.2") String repoRole, | ||
| @Nullable @QueryParam("permission.2.projectKey") String repoProjectKey, | ||
| @Nullable @QueryParam("permission.3.projectId") String repoPrrojectId, |
There was a problem hiding this comment.
So we could have N number of these which is going to make this a bit unruly and also limit folks if we only specify 3. We'll probably have to create an optional Binder which will take in a list of of these "permission objects" which we will then have to inject the values as query-params. Take a look HERE and poke around the code base to see how we do this type of thing elsewhere. Let me know if you have any questions. Looks good so far.
There was a problem hiding this comment.
I'm sorry I misunderstood the documentation I thought permission was for global 1 was for project permissions and 2 for repo etc.. I didn't recognize they were the same thing but different filters.
I looked into what you told me, isn't that a way to bind some data to the payload? which is as much as I know should not be used with GET requests as their body is not processed? Please correct me if I misunderstood anything.
There was a problem hiding this comment.
Ignore the class name ... you can alter the request in general and append new query params/etc. Take a look at the below code where we do something like this:
There was a problem hiding this comment.
I am sorry I have to postpone it to the next Friday, as am having my midterm exams this week and I got a lot of studying to do.
There was a problem hiding this comment.
@ajammil of course and take your time.
I did the first endpoint, but I need the feedback.
Also in the Mock test for the UserApi, I disabled the assertSent function as it gave me errors. Could you tell me what I did wrong?
Thank you in advance.
This PR is targeting issue #183 .