Added Spark Source interface #13661
Open
Added Spark Source interface #13661
+139
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tivv
reviewed
Sep 1, 2021
| * | ||
| * @param context {@link SparkExecutionPluginContext} for this job | ||
| */ | ||
| public abstract JavaRDD<OUT> run(SparkExecutionPluginContext context) throws Exception; |
There was a problem hiding this comment.
Can we have a different name? E.g. read or create? Also javadoc needs to be corrected as reading do not really execute any jobs nor persist data
There was a problem hiding this comment.
oops, let me fix the javadoc and rename this method
fernst
force-pushed
the
create-spark-source-interface
branch
from
ca8a496 to
6415537
Compare
albertshau
approved these changes
Sep 2, 2021
| private static final long serialVersionUID = 4829903051232692690L; | ||
|
|
||
| /** | ||
| * User Spark job which will be executed and is responsible for generating a new RDD for the resf of the pipeline |
There was a problem hiding this comment.
'job' is a misleading term here since this method won't normally trigger a physical Spark job unless somebody implements it by calling some Spark actions. Think it's better to leave out the first part and just say 'Responsible for ...'
tivv
reviewed
Sep 2, 2021
|
|
||
| public static final String PLUGIN_TYPE = "sparksource"; | ||
|
|
||
| private static final long serialVersionUID = 4829903051232692690L; |
There was a problem hiding this comment.
Do you need a serialVersionUID on an abstract class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface will be used to create Spark RDDs and RDDCollection entities from Spark programs.
This will be useful when integrating the Spark BigQuery Connector for BQ Pushdown execution https://github.com/GoogleCloudDataproc/spark-bigquery-connector