Skip to content

Conversation

@afrittoli
Copy link
Contributor

Changes

Rename context/version to context/specversion to avoid confusion between the specification version and the event version.

Fixes: #112

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

@afrittoli afrittoli requested a review from a team as a code owner November 6, 2025 10:45
afrittoli added a commit to afrittoli/cdevents.dev that referenced this pull request Nov 6, 2025
Merge after cdevents/spec#273 has been
merged and v0.5 has been released.

Signed-off-by: Andrea Frittoli <[email protected]>
Rename context/version to context/specversion to avoid confusion
between the specification version and the event version.

Fixes: cdevents#112

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli force-pushed the version_specversion branch from bca2687 to 77280b9 Compare November 6, 2025 10:51
Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I imagine all of the code generators for all the SDK will need to be updated to support this

@afrittoli
Copy link
Contributor Author

Looks good. I imagine all of the code generators for all the SDK will need to be updated to support this

Yes, all the SDKs will need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Versioning field in the context part is confusing, maybe rename to specversion

2 participants