Skip to content

fix(test): test subject were missing format on subject.source - #303

Closed
xibz wants to merge 1 commit into
cdevents:mainfrom
xibz:consistency
Closed

fix(test): test subject were missing format on subject.source#303
xibz wants to merge 1 commit into
cdevents:mainfrom
xibz:consistency

Conversation

@xibz

@xibz xibz commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: xibz <impactbchang@gmail.com>
@xibz
xibz requested a review from afrittoli March 25, 2026 15:05
@xibz
xibz requested a review from a team as a code owner March 25, 2026 15:05
@xibz xibz changed the title fix(test): test subject were missing format on subject.source fix(test): test subject.source were missing format on subject.source Mar 25, 2026
@xibz xibz changed the title fix(test): test subject.source were missing format on subject.source fix(test): test subject were missing format on subject.source Mar 25, 2026

@afrittoli afrittoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but I wonder if it is really necessary, in light of #302, where source will be merged into id

@xibz

xibz commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

@afrittoli yes good point!

@xibz xibz closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants