fix: most eslint rules have moved to @stylistic #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint has moved most of it's style-related linter rules to a namespace called `@stylistic`. Update our built-in linter rules to reference those rules in the new package name, and change the public interface to accept arbitrary strings, instead of an enum from a specific set of rules.
|
@aws-cdk/aws-service-spec: No model change detected |
iliapolo
reviewed
Dec 18, 2024
| @@ -16,7 +16,7 @@ describe('statements', () => { | |||
| fn.addBody(code.comment('test comment')); | |||
|
|
|||
| expect(renderer.render(scope)).toMatchInlineSnapshot(` | |||
| "/* eslint-disable prettier/prettier, max-len */ | |||
| "/* eslint-disable prettier/prettier, @stylistic/max-len */ | |||
There was a problem hiding this comment.
Does this mean though that consumers who don't have the stylistic plugin won't have this suppression now? is that a thing we care about?
There was a problem hiding this comment.
I don't care about it, frankly.
But given that referencing non-existing rules in an eslint-disable directive is an error, we probably shouldn't have been putting linter rules in there to begin with.
There was a problem hiding this comment.
Yeah seems fragile. Ok, lets see if this causes any pain
There was a problem hiding this comment.
+1 I think the better pattern is to run a formatter/linter over the code afterwards. Most of the rule validations should be auto-fixable anyway.
iliapolo
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint has moved most of it's style-related linter rules to a namespace called
@stylistic.Update our built-in linter rules to reference those rules in the new package name, and change the public interface to accept arbitrary strings, instead of an enum from a specific set of rules.