forked from eclipse-mosquitto/mosquitto
-
Notifications
You must be signed in to change notification settings - Fork 0
add mosquitto_delay_puback option #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
linuxbasic
wants to merge
2
commits into
master
Choose a base branch
from
feat/delayed-puback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazzaretti
requested changes
Dec 6, 2020
Lazzaretti
requested changes
Dec 6, 2020
d275f90
to
7886aa8
Compare
Lazzaretti
reviewed
Dec 6, 2020
86e16bc
to
5de28da
Compare
Lazzaretti
reviewed
Dec 6, 2020
5de28da
to
2e4470c
Compare
Signed-off-by: Linus Basig <[email protected]> Co-authored-by: Fabrizio Lazzaretti <[email protected]> Signed-off-by: Fabrizio Lazzaretti <[email protected]>
2e4470c
to
3841c91
Compare
9f834df
to
feeca2b
Compare
Signed-off-by: Linus Basig <[email protected]> Co-authored-by: Fabrizio Lazzaretti <[email protected]> Signed-off-by: Fabrizio Lazzaretti <[email protected]>
feeca2b
to
7934634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Linus Basig [email protected]
Signed-off-by: Fabrizio Lazzaretti [email protected]
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
If you are contributing a bugfix, is your work based off the fixes branch?make test
with your changes locally?This PR adds a method
mosquitto_delay_puback
. After callingmosquitto_delay_puback
the library will delay the PUBACK message required for QoS 1 message transfers until after theon_message
callback returns.This change ensures the message does not get lost if the client crashes during the processing of the message.
If the
mosquitto_delay_puback
is not called, the previous behavior (PUBACK before callingon_message
) applies.related issues:
My use-case is a messaging middleware that forwards the messages to other systems and we need to maintain the "At Least Once" delivery guarantee of QoS 1.