update oopsla benchmark to use latest version #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaobo-he-aws
approved these changes
Sep 23, 2024
cdisselkoen
approved these changes
Sep 30, 2024
oopsla2024-benchmarks/Cargo.toml
Outdated
Comment on lines
10
to
12
| cedar-policy-core = { git = "https://github.com/cedar-policy/cedar-spec", branch = "release/3.0.x", version = "=3.0.1" } | ||
| cedar-policy-generators = { git = "https://github.com/cedar-policy/cedar-spec", branch = "release/3.0.x", version = "=3.0.1" } | ||
| cedar-policy-validator = { git = "https://github.com/cedar-policy/cedar-spec", branch = "release/3.0.x", version = "=3.0.1" } | ||
| cedar-policy-core = { path = "cedar-spec/cedar/cedar-policy-core", version = "=4.0.0" } | ||
| cedar-policy-generators = { path = "cedar-spec/cedar-policy-generators", version = "=4.0.0" } | ||
| cedar-policy-validator = { path = "cedar-spec/cedar/cedar-policy-validator", version = "=4.0.0" } |
There was a problem hiding this comment.
why moving from git dependency to path dependency? or for that matter could we perhaps even depend on crates.io 4.0?
There was a problem hiding this comment.
Since this is going to main, the intent was to pull the "latest" version. Since we've bumped to 4.1.0 on main now, I'll move to that. Alternatively: is there a way to get "whatever version is at that path"?
There was a problem hiding this comment.
Aha, makes sense. Updated in the latest commit.
Co-authored-by: Craig Disselkoen <[email protected]>
cdisselkoen
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update the OOPSLA benchmarking code (on the
mainbranch) to use the latest version of Cedar.Also updates
cedar-rust-hello-worldandcedar-wasm-exampleto use the latest versions.