Skip to content

Use stable channel to build CedarJavaFFI in CI #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

shaobo-he-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

@john-h-kastner-aws
Copy link
Contributor

what has changed since #191?

@shaobo-he-aws
Copy link
Contributor Author

shaobo-he-aws commented Jan 2, 2025

what has changed since #191?

My bad. I should've tracked it better. My hunch is that zigbuild finally caught up. Please refer to cedar-policy/cedar-java#273.

@shaobo-he-aws
Copy link
Contributor Author

We can merge this PR anyways.

Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed that it's good to test against stable in CI, then we know if zigbuild breaks on a future Rust stable release

@shaobo-he-aws shaobo-he-aws merged commit 286c398 into main Jan 3, 2025
9 checks passed
@shaobo-he-aws shaobo-he-aws deleted the chore/shaobo/update-ci branch January 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants