Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update corpus tests #10

Merged
merged 1 commit into from
Sep 3, 2024
Merged

update corpus tests #10

merged 1 commit into from
Sep 3, 2024

Conversation

khieta
Copy link
Contributor

@khieta khieta commented Aug 30, 2024

Issue #, if available:

Description of changes:

Followup to #7 and #8, updating the corpus tests on main. This should be the last round of updates for now. Here are the results of the corpus comparison script:

Original New Difference
Total test cases 1982 5096 3114
Unique policies 1048 ( 52.9% ) 2605 ( 51.1% ) 1557
Unique schemas 631 ( 31.8% ) 2131 ( 41.8% ) 1500
Unique entity stores 918 ( 46.3% ) 2970 ( 58.3% ) 2052
Entities per entity store mean: 1 / median: 1 / p90: 2 mean: 1 / median: 1 / p90: 6 n/a
Schema entity types mean: 1 / median: 1 / p90: 1 mean: 1 / median: 1 / p90: 5 n/a
Schema actions mean: 1 / median: 1 / p90: 1 mean: 1 / median: 1 / p90: 1 n/a
Trivial policies 834 ( 42.1% ) 2293 ( 45.0% ) 1459
Pure RBAC (non-trivial) policies 436 ( 22.0% ) 693 ( 13.6% ) 257
Pure ABAC (non-trivial) policies 60 ( 3.0% ) 90 ( 1.8% ) 30

No idea why the previous corpus was so small. But we can track changes more easily now with the comparison script.

@khieta
Copy link
Contributor Author

khieta commented Aug 30, 2024

CI is passing, so marking as ready for review

@khieta khieta marked this pull request as ready for review August 30, 2024 19:24
@khieta khieta merged commit 3903b93 into main Sep 3, 2024
5 checks passed
@khieta khieta deleted the khieta/update-corpus branch September 3, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants