Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Runtime and Test Dependencies #82

Merged

Conversation

exceptionfactory
Copy link
Contributor

Issue #, if available:

Description of changes:

This pull request upgrades project dependencies to current versions and removes several unused test dependencies.

Upgraded libraries include the following:

  • Upgraded Gradle from 8.1.1 to 8.6
  • Upgraded Jackson from 2.15.0 to 2.16.1
  • Upgraded SLF4J from 2.0.7 to 2.0.12
  • Upgraded JUnit from 5.9.3 to 5.10.2
  • Upgraded jqwik from 1.7.3 to 1.8.2

Changes and removals include the following:

  • Replaced Log4j 2 with SLF4J Simple implementation for testing
  • Replaced FindBugs 3.0.1 with SpotBugs 4.8.3
  • Removed unused Mockito Inline dependency
  • Removed unused SLF4J Reload4j

The slf4j-simple library defaults to writing INFO level messages to the console, which is the same behavior as the test Log4j 2 configuration. The slf4j-simple library also supports configurable logging levels using system properties, which supports options like trace levels when needed.

The FindBugs 3.01 library was released in 2015, and spotbugs-annotations provides the maintained version fork with the same annotations. The EntityUIDTests class had an unused import for org.apache.bcel.generic.IDIV, which was previously provided through a transitive dependency of FindBugs 3.0.1.

The mockito-inline dependency was not used.

The slf4j-reload4j library is a patched implementation of Log4j 1, which is not needed for testing with slf4j-simple providing console logging.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Upgraded Gradle from 8.1.1 to 8.6
- Upgraded Jackson from 2.15.0 to 2.16.1
- Upgraded SLF4J from 2.0.7 to 2.0.12
- Upgraded JUnit from 5.9.3 to 5.10.2
- Upgraded jqwik from 1.7.3 to 1.8.2
- Replaced Log4J 2 with SLF4J Simple implementation for testing
- Replaced FindBugs 3.0.1 with SpotBugs 4.8.3
- Removed unused Mockito Inline dependency
- Removed unused SLF4J Reload4j
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to this project!

@exceptionfactory
Copy link
Contributor Author

Thanks for the improvements to this project!

You're welcome, glad to help!

@andrewmwells-amazon andrewmwells-amazon merged commit 4fcfe7e into cedar-policy:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants