Skip to content

Upgraded cedar to 4.2.0#83

Merged
ShiromMakkad merged 10 commits intocedar-policy:mainfrom
l-kli:main
Dec 4, 2024
Merged

Upgraded cedar to 4.2.0#83
ShiromMakkad merged 10 commits intocedar-policy:mainfrom
l-kli:main

Conversation

@l-kli
Copy link
Copy Markdown
Contributor

@l-kli l-kli commented Nov 13, 2024

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-local-agent (e.g., changes to the signature of an
    existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-local-agent (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-local-agent.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor
    version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

Testing

Add a description on how the code changes were tested, if applicable.

Hint: run ./scripts/build_and_test.sh script to validate your changes locally before submitting a PR.

@l-kli l-kli force-pushed the main branch 4 times, most recently from 061ae6f to 1d705f9 Compare November 14, 2024 17:41
Signed-off-by: Kelley Li <lkli@amazon.com>
Signed-off-by: Kelley Li <lkli@amazon.com>
@ShiromMakkad ShiromMakkad self-assigned this Nov 19, 2024
@ShiromMakkad ShiromMakkad self-requested a review November 19, 2024 22:12
@l-kli l-kli force-pushed the main branch 6 times, most recently from faead02 to 445ca2a Compare November 19, 2024 22:49
@github-actions
Copy link
Copy Markdown

Coverage after merging main into main

93.01%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs47.81%100%25.55%95.29%202, 236–239, 372–375, 532, 917, 926
   mod.rs65.63%100%61.40%100%

Comment thread deny.toml
Comment thread src/public/log/schema.rs Outdated
Comment thread src/public/log/schema.rs Outdated
Comment thread src/public/log/schema.rs Outdated
Comment thread src/public/simple.rs Outdated
Comment thread src/public/simple.rs Outdated
Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread src/public/log/schema.rs Outdated
@adamrothman
Copy link
Copy Markdown
Contributor

Thanks for opening this @l-kli – I'm looking forward to being able to upgrade to Cedar 4.

@github-actions
Copy link
Copy Markdown

Coverage after merging main into main

93.81%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs48.38%100%25.69%96.86%202, 372–375, 532, 917, 926
   mod.rs65.63%100%61.40%100%

Signed-off-by: Kelley Li <lkli@amazon.com>
@github-actions
Copy link
Copy Markdown

Coverage after merging main into main

93.81%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs48.38%100%25.69%96.86%202, 372–375, 532, 917, 926
   mod.rs65.63%100%61.40%100%

1 similar comment
@github-actions
Copy link
Copy Markdown

Coverage after merging main into main

93.81%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs48.38%100%25.69%96.86%202, 372–375, 532, 917, 926
   mod.rs65.63%100%61.40%100%

Comment thread src/public/log/schema.rs
Comment thread src/public/log/schema.rs
Comment thread deny.toml
Comment thread src/public/log/schema.rs Outdated
Comment thread src/public/log/schema.rs
Comment thread benches/data_gen/utils.rs
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2024

Coverage after merging main into main

93.86%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs48.63%100%25.69%96.91%202, 376–379, 536, 923, 932
   mod.rs65.63%100%61.40%100%

Signed-off-by: Kelley Li <lkli@amazon.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2024

Coverage after merging main into main

93.86%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs48.63%100%25.69%96.91%202, 376–379, 536, 923, 932
   mod.rs65.63%100%61.40%100%

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2024

Coverage after merging main into main

93.86%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/public
   mod.rs8.33%100%8.33%100%
   simple.rs60%100%58.33%71.43%176–179
src/public/events
   receive.rs85.19%100%88.89%77.78%28, 36
   core.rs76.67%100%90%70%156–158, 163–165, 170, 54–55, 77–79
src/public/file
   policy_set_provider.rs88.79%100%81.82%98%175
   entity_provider.rs84.86%100%75.26%95.45%228, 247–249
src/public/log
   event.rs90.63%100%75%100%
   error.rs76.92%100%57.14%100%
   schema.rs48.63%100%25.69%96.91%202, 376–379, 536, 923, 932
   mod.rs65.63%100%61.40%100%

@ShiromMakkad ShiromMakkad merged commit ab31fff into cedar-policy:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants