Upgraded cedar to 4.2.0 #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-kli
force-pushed
the
main
branch
4 times, most recently
from
061ae6f
to
1d705f9
Compare
Signed-off-by: Kelley Li <[email protected]>
Signed-off-by: Kelley Li <[email protected]>
Signed-off-by: Kelley Li <[email protected]>
l-kli
force-pushed
the
main
branch
6 times, most recently
from
faead02
to
445ca2a
Compare
|
Coverage after merging main into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ShiromMakkad
requested changes
Nov 20, 2024
|
Thanks for opening this @l-kli – I'm looking forward to being able to upgrade to Cedar 4. |
|
Coverage after merging main into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Signed-off-by: Kelley Li <[email protected]>
|
Coverage after merging main into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging main into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @@ -1078,20 +1079,31 @@ mod test { | |||
| policy_ids.insert(PolicyId::from_str("policy1").unwrap()); | |||
| policy_ids.insert(PolicyId::from_str("policy2").unwrap()); | |||
There was a problem hiding this comment.
You don't need policy_ids anymore
| let auth_res = authorizer.is_authorized(&request, &policy_set, &Entities::empty()); | ||
| let auth_err = auth_res.diagnostics().errors().next().unwrap(); | ||
|
|
||
| let errors: Vec<AuthorizationError> = (0..num_of_error).map(|_| auth_err.clone()).collect(); |
| targets = [] | ||
|
|
||
| [advisories] | ||
| vulnerability = "deny" |
There was a problem hiding this comment.
Looks like the changes to deny.toml are still here. Ideally, I don't want any changes on this file. We still don't want deps with vulnerabilities, that are unlicensed, unmaintained, etc to be allowed in the crate.
| UserName = 4, | ||
| /// Email address. For example: john_doe@example.com | ||
| /// Email address. For example: john\_doe@example.com |
There was a problem hiding this comment.
nit: Is this needed to appease clippy if you don't have backticks? Tbh, backticks were a better solution than escaping the _.
| @@ -1140,6 +1158,15 @@ mod test { | |||
| assert_eq!(ocsf_log.status_code.unwrap(), "Deny".to_string()); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn build_ocsf_severity_multiple_errors() { | |||
| @@ -2,13 +2,14 @@ use rand::Rng; | |||
|
|
|||
| /// Alphabet as an &str | |||
| pub const ALPHA: &str = "abcdefghijklmnopqrstuvwxyz"; | |||
| #[allow(clippy::single_char_add_str)] | |||
There was a problem hiding this comment.
nice, right approach here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-local-agent(e.g., changes to the signature of anexisting API).
cedar-local-agent(e.g., addition of a new API).cedar-local-agent.I confirm that this PR (choose one, and delete the other options):
version bumps).
Testing
Add a description on how the code changes were tested, if applicable.
Hint: run
./scripts/build_and_test.shscript to validate your changes locally before submitting a PR.