Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the is operator to Dafny #153

Merged
merged 10 commits into from
Nov 16, 2023
Merged

Add the is operator to Dafny #153

merged 10 commits into from
Nov 16, 2023

Conversation

khieta
Copy link
Contributor

@khieta khieta commented Nov 15, 2023

Issue #, if available:

Description of changes:

Add the is operator to Dafny, matching the corresponding implementation in Lean (#138).

Will mark as ready for review once I've tested that it works with #145.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

john-h-kastner-aws and others added 6 commits November 8, 2023 15:47
Generators may generate `is` based on an `enable_is` flag. This is
disabled for differential testing because `is` is not modeled in dafny,
but it is enabled for property tests.
@khieta
Copy link
Contributor Author

khieta commented Nov 16, 2023

Marking as ready for review. I ran the DRT targets locally (w/ #155) for a few minutes, and didn't see any failures. Will rely on our nightly fuzzing runs to find more subtle issues.

@khieta khieta marked this pull request as ready for review November 16, 2023 13:56
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the proofs/lemmas, but the rest of the changes look reasonable

@khieta khieta merged commit c80bb47 into main Nov 16, 2023
3 checks passed
@khieta khieta deleted the dafny-is-operator branch November 16, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants