Fix LeanFFI #246
Merged
Fix LeanFFI #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmwells-amazon
force-pushed
the
andrewmwells/lean-ffi-threading
branch
from
3a57463
to
4c42ca6
Compare
|
Awesome progress! Thanks for looking into this 🙂 |
andrewmwells-amazon
force-pushed
the
andrewmwells/lean-ffi-threading
branch
from
908b779
to
e499de2
Compare
|
The tests now run but Lean folks said this shouldn't work. Waiting for clarification on this thread: https://leanprover.zulipchat.com/#narrow/stream/424609-lean-at-aws/topic/Reverse.20FFI.20Thread.20Safety before we can merge. |
|
Lean PR. We need to wait until we upgrade to that Lean version before we fix+merge this. |
khieta
reviewed
Mar 7, 2024
Signed-off-by: Andrew Wells <[email protected]>
andrewmwells-amazon
force-pushed
the
andrewmwells/lean-ffi-threading
branch
from
e499de2
to
703dea3
Compare
Signed-off-by: Andrew Wells <[email protected]>
andrewmwells-amazon
force-pushed
the
andrewmwells/lean-ffi-threading
branch
from
703dea3
to
18f24e5
Compare
|
Does not allow multiple LeanFFI threads, but should fix a memory leak. |
khieta
approved these changes
Apr 5, 2024
aaronjeline
approved these changes
Apr 8, 2024
shaobo-he-aws
pushed a commit
that referenced
this pull request
Apr 11, 2024
shaobo-he-aws
added a commit
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Shaobo He <[email protected]> Co-authored-by: Andrew Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#227
Description of changes:
Fix LeanFFI to work with multiple threads.Also decrement reference count on responses to fix memory leak.Threads issue is blocked on leanprover/lean4#3632 being released. This PR now purely fixes the memory leak.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.