Updates for cedar#837 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-h-kastner-aws
approved these changes
Jun 4, 2024
|
Note: integration tests are expected to fail due to cedar#837. That failure will be resolved by a PR to |
cdisselkoen
approved these changes
Jun 4, 2024
cdisselkoen
reviewed
Jun 4, 2024
| @@ -180,7 +179,7 @@ impl LeanDefinitionalEngine { | |||
| // coerce to PolicyId just to ensure it's valid | |||
There was a problem hiding this comment.
this comment might be outdated now
There was a problem hiding this comment.
Oops, too quick with my merge - will try to remember to update next time I touch this code (this will likely be soon as I continue to muck with the FFI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes for cedar#837 (not yet merged) and cedar#946 (already merged).