-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lean: Add parsing for duration
in the datetime
extension
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
adpaco-aws
force-pushed
the
parse-duration
branch
from
November 8, 2024 21:45
afcdac8
to
0d87b61
Compare
emina
requested changes
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Left some comments.
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
Signed-off-by: Adrian Palacios <[email protected]>
adpaco-aws
force-pushed
the
parse-duration
branch
from
November 22, 2024 22:32
23c68ea
to
ca2a459
Compare
emina
reviewed
Nov 22, 2024
Signed-off-by: Adrian Palacios <[email protected]>
emina
reviewed
Nov 25, 2024
Signed-off-by: Adrian Palacios <[email protected]>
emina
approved these changes
Nov 25, 2024
john-h-kastner-aws
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes
This PR adds parsing for
duration
strings in thedatetime
extension which is being introduced to the Lean models.We define a
parse
function that attempts to parse aduration
string from the back. This helps us avoid an issue with respect to our previous forward version where this greedy approach leads to failures due to them
unit being a substring of thems
unit. The changes also include unit tests for parsing duration strings.Callouts
parse
function fordatetime
values, so I'm not sure what's the best way to name theparse
in these changes. Do we want another namespace for theduration
definitions?