remove most of the panics and panic-indexing from Protobuf module #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
cdisselkoen
requested review from
emina,
adpaco-aws and
AMZ-brandon
and removed request for
AMZ-brandon
emina
approved these changes
Dec 3, 2024
adpaco-aws
approved these changes
Dec 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places we were first checking-for-empty and then panic-indexing to get the next byte. Refactored this to use a new helper
nextBytethat returnsOption. Also overhauledutf8DecodeCharto actually consume the bytes as it goes, rather than the previous behavior of use-but-not-consume them and return an integer indicating how much the iterator needs to be advanced. Overhauled the proof ofutf8DecodeChar.progressto now prove that it progresses the iterator, rather than returns a positive integer.