Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common type target for reserved type names (3.4.x) #495

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Fix common type target for reserved type names (3.4.x) #495

merged 4 commits into from
Dec 18, 2024

Conversation

john-h-kastner-aws
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws commented Dec 17, 2024 •
edited
Loading

Issue #, if available:

Needs cedar-policy/cedar#1378

Description of changes:

@john-h-kastner-aws john-h-kastner-aws mentioned this pull request Dec 17, 2024
Merged
14 tasks
@john-h-kastner-aws john-h-kastner-aws changed the title Fix common type target for reserved type names Fix common type target for reserved type names (3.4.x) Dec 17, 2024
cdisselkoen
cdisselkoen approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these changes are already on main?

@john-h-kastner-aws
Copy link
Contributor Author

john-h-kastner-aws commented Dec 17, 2024 •
edited
Loading

I assume these changes are already on main?

Not precisely these changes, but the problem doesn't effect main (or 4.x) because we introduced a CommonTypeId struct with an arbitrary impl that never generates reserved type names.

@john-h-kastner-aws
fix deprecated functions
ff51ee0 
Signed-off-by: John Kastner <[email protected]>
@john-h-kastner-aws
update submodule
de22c3e 
Signed-off-by: John Kastner <[email protected]>
@john-h-kastner-aws
fix deprecated functions
4d5ea9d 
Signed-off-by: John Kastner <[email protected]>
@john-h-kastner-aws
Copy link
Contributor Author

build errors finally fixed. just need another approval

@john-h-kastner-aws john-h-kastner-aws merged commit 7993dce into release/3.4.x Dec 18, 2024
5 checks passed
@john-h-kastner-aws john-h-kastner-aws deleted the fix-common-type-target branch December 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaobo-he-aws shaobo-he-aws shaobo-he-aws approved these changes

@cdisselkoen cdisselkoen cdisselkoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-h-kastner-aws @cdisselkoen @shaobo-he-aws