Fix SMT encoding of string literals#640
Merged
Merged
Conversation
zhengyao-lin
force-pushed
the
encoder-str-bug
branch
from
0647bbc to
2ebece3
Compare
lianah
approved these changes
Jun 16, 2025
emina
approved these changes
Jun 16, 2025
cdisselkoen
approved these changes
Jun 17, 2025
zhengyao-lin
force-pushed
the
encoder-str-bug
branch
from
5638835 to
132c60e
Compare
cdisselkoen
approved these changes
Jun 17, 2025
Signed-off-by: Zhengyao Lin <zyal@amazon.com>
Signed-off-by: Zhengyao Lin <zyal@amazon.com>
zhengyao-lin
force-pushed
the
encoder-str-bug
branch
from
132c60e to
579e9e6
Compare
cdisselkoen
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #636
Description of changes:
Escape character
"correctly inencodeString(which is the only type of escape sequence per SMT-LIB standard).The added test would get stuck without this fix (not entirely sure why, but presumably due to CVC5 waiting more string contents since an invalid string literal
"""is fed into it).