Adds a dockerfile to build and run cedar-lean-cli.#644
Merged
Conversation
…ructions accordingly. Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
2 tasks
katherine-hough
approved these changes
Jun 23, 2025
Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
katherine-hough
approved these changes
Jun 23, 2025
cdisselkoen
approved these changes
Jun 24, 2025
Comment on lines
+35
to
+36
| FROM prepare AS build | ||
|
|
Contributor
There was a problem hiding this comment.
Does this have any effect, given that prepare was the immediately preceding layer?
Author
There was a problem hiding this comment.
Not sure. I copied this from an existing DockerFile.
Contributor
There was a problem hiding this comment.
| ``` | ||
| # Create a docker image that is identified with the tag "cedar-lean-cli" | ||
| cd cedar-lean-cli # Enter the cedar-lean-cli directory | ||
| docker build -t cedar-lean-cli -f ./Dockerfile .. |
Contributor
There was a problem hiding this comment.
I think -f ./Dockerfile is the default?
Author
There was a problem hiding this comment.
I don't believe so.
I believe the default behavior is to look for Dockerfile within the build context (..) and not the current working directory (.).
| docker build -t cedar-lean-cli -f ./Dockerfile .. | ||
|
|
||
| # Create and enter a container using the newly created cedar-lean-cli docker image | ||
| docker run -it cedar-lean-cli |
Contributor
There was a problem hiding this comment.
possibly recommend --rm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #635 by adding a new Dockerfile that creates a docker image that pre-installs cedar-lean-cli and all of its dependencies.
To build:
Create and enter a container running the newly created docker image: